From dc71bf6390706ca411e236092199b70213d998f9 Mon Sep 17 00:00:00 2001 From: Davin Chia Date: Tue, 14 Sep 2021 13:00:36 +0800 Subject: [PATCH] =?UTF-8?q?=F0=9F=8D=BE=20=20Remove=20automatic=20filterin?= =?UTF-8?q?g=20of=20system=20schemas=20from=20Oracle=20source.=20(#6038)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove default schemas from Oracle source. * Bump version and update changelog. --- .../init/src/main/resources/seed/source_definitions.yaml | 2 +- airbyte-integrations/connectors/source-oracle/Dockerfile | 2 +- .../airbyte/integrations/source/oracle/OracleSource.java | 7 +++++-- docs/integrations/sources/oracle.md | 1 + 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index d18f4daa0d17..2499291fd05d 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -289,7 +289,7 @@ - sourceDefinitionId: b39a7370-74c3-45a6-ac3a-380d48520a83 name: Oracle DB dockerRepository: airbyte/source-oracle - dockerImageTag: 0.3.3 + dockerImageTag: 0.3.4 documentationUrl: https://docs.airbyte.io/integrations/sources/oracle - sourceDefinitionId: c8630570-086d-4a40-99ae-ea5b18673071 name: Zendesk Talk diff --git a/airbyte-integrations/connectors/source-oracle/Dockerfile b/airbyte-integrations/connectors/source-oracle/Dockerfile index f21d756510ff..4ffe7bcf46d6 100644 --- a/airbyte-integrations/connectors/source-oracle/Dockerfile +++ b/airbyte-integrations/connectors/source-oracle/Dockerfile @@ -9,5 +9,5 @@ COPY build/distributions/${APPLICATION}*.tar ${APPLICATION}.tar RUN tar xf ${APPLICATION}.tar --strip-components=1 -LABEL io.airbyte.version=0.3.3 +LABEL io.airbyte.version=0.3.4 LABEL io.airbyte.name=airbyte/source-oracle diff --git a/airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java b/airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java index b145f81d7884..2410197f24ab 100644 --- a/airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java +++ b/airbyte-integrations/connectors/source-oracle/src/main/java/io/airbyte/integrations/source/oracle/OracleSource.java @@ -94,10 +94,13 @@ public List>> discoverInternal(JdbcDatabase data return internals; } + /** + * Since the Oracle connector allows a user to specify schemas, and picks a default schemas + * otherwise, system tables are never included, and do not need to be excluded by default. + */ @Override public Set getExcludedInternalNameSpaces() { - // need to add SYSTEM too but for that need create another user when creating the container. - return Set.of("APEX_040000", "CTXSYS", "SYSTEM", "FLOWS_FILES", "HR", "MDSYS", "OUTLN", "SYS", "XDB"); + return Set.of(); } public static void main(String[] args) throws Exception { diff --git a/docs/integrations/sources/oracle.md b/docs/integrations/sources/oracle.md index e368630dff2e..e2532c778fc3 100644 --- a/docs/integrations/sources/oracle.md +++ b/docs/integrations/sources/oracle.md @@ -105,5 +105,6 @@ Case sensitive. Defaults to the upper-cased user if empty. If the user does not | Version | Date | Pull Request | Subject | | :------ | :-------- | :----- | :------ | +| 0.3.4 | 2021-09-01 | [6038](https://github.com/airbytehq/airbyte/pull/6038) | Remove automatic filtering of system schemas. | | 0.3.3 | 2021-09-01 | [5779](https://github.com/airbytehq/airbyte/pull/5779) | Ability to only discover certain schemas. | | 0.3.2 | 2021-08-13 | [4699](https://github.com/airbytehq/airbyte/pull/4699) | Added json config validator. |