Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Source Shopify to Cloud #10281

Closed
8 of 12 tasks
misteryeo opened this issue Feb 11, 2022 · 19 comments
Closed
8 of 12 tasks

[EPIC] Source Shopify to Cloud #10281

misteryeo opened this issue Feb 11, 2022 · 19 comments

Comments

@bazarnov
Copy link
Collaborator

bazarnov commented Feb 14, 2022

@misteryeo

  • Implement 'tender_transactions' stream

It's already there, inside of Transactions stream, providing both transaction details and the user bounded to the transaction per each order_id.

  • Support incremental deletes

Shopify does not provide the functionality to retrieve the removed records either using UI or using API calls. They suggesting to use the backups and restore from them once needed.

Considering the answer, what are the future steps for this task?

@bazarnov bazarnov self-assigned this Feb 14, 2022
@misteryeo
Copy link
Contributor Author

Thanks @bazarnov - are you able to work with @ycherniaiev to ensure the research document is updated to reflect the result of your investigation on tender_transactions?

@sherifnada any thoughts on the incremental deletes?

@bazarnov
Copy link
Collaborator

Thanks @bazarnov - are you able to work with @ycherniaiev to ensure the research document is updated to reflect the result of your investigation on tender_transactions?

We've already aligned yesterday on the daily meeting. This subject was discussed. The tender_transactions is the subset of 2 different data objects: Orders + Transactions, with the small amount of fields that includes user_id, order_id and payment_details, basically speaking it's a preset used in GraphQL to make an aggregated result, instead of joining 2 different tables afterwards. We already have Orders, Transactions as separate streams, the user can make all the mutations after the sync on their side.

@ycherniaiev
Copy link
Contributor

ycherniaiev commented Feb 17, 2022

Thanks @bazarnov - are you able to work with @ycherniaiev to ensure the research document is updated to reflect the result of your investigation on tender_transactions?

@sherifnada any thoughts on the incremental deletes?

@misteryeo @bazarnov Document is updated. Tender_transactions is still a separate stream by Fivetran according to https://fivetran.com/docs/applications/shopify#schemainformation. So made a note.

@sherifnada
Copy link
Contributor

@bazarnov @misteryeo for incremental deletes: I think we can get them via webhooks, but that's not going to happen by EOQ. So I think we should create a ticket with this context but consider it non-blocking for beta

@misteryeo
Copy link
Contributor Author

Sounds good, let's move forward with this suggestion @bazarnov

@bazarnov
Copy link
Collaborator

UPDATE:
Within the latest API version: 2022-01 we are now able to fetch the tender_transactions data directly from the endpoint.
https://shopify.dev/api/admin-rest/2022-01/resources/tendertransaction#[get]/admin/api/2022-01/tender_transactions.json?processed_at_max=2005-08-05%2010:22:51%20-0400

I'm going to implement and release it ASAP, due to Beta requirements.

@bazarnov
Copy link
Collaborator

UPDATE:

The #10448 is implemented and merged into master last week.
The other thing: Support incremental deletes is not currently possible to implement, due to the fact that we don't have the possibility to track the removed records within the data.

Is there anything else we should cover for the Beta status at this moment?

@misteryeo
Copy link
Contributor Author

misteryeo commented Mar 2, 2022

Updated the description to reflect some outstanding bugs @bazarnov

Have also added comments in the spreadsheet after reviewing UX/docs that need your help updating. Thanks!

@bazarnov
Copy link
Collaborator

bazarnov commented Mar 2, 2022

#10379
#10451

These 2 issues are related and should be fixed by: #10794

Source Shopify: KeyError during normalization #9976

This one is just the matter of updating the connector >= 0.1.31

#10595

Not sure this is the actual issue at all. I've tested the sync, it was successful, I've also commented in this issue to describe the mechanism of child stream work.

@bazarnov
Copy link
Collaborator

bazarnov commented Mar 2, 2022

Updated the description to reflect some outstanding bugs @bazarnov

Have also added comments in the spreadsheet after reviewing UX/docs that need your help updating. Thanks!

Also, in this PR the specification and documentation were updated as well, based on review comments in the spreadsheet, the spreadsheet was updated as well, see the COMMENTS column for status.

@bazarnov
Copy link
Collaborator

bazarnov commented Mar 9, 2022

Update:

All listed Outstanding Bugs are resolved and merged into master.

@erica-airbyte
Copy link
Contributor

@misteryeo Created this issue for showing the correct connector phase label for Shopify

@misteryeo
Copy link
Contributor Author

Update:
@girarda is resolving some blockers to get Shopify’s OAuth approval. Once that is done, we’ll let @bazarnov know so he can complete this epic.

@sherifnada
Copy link
Contributor

@bazarnov I've unassigned this issue from you pending completion of #11334

@bazarnov
Copy link
Collaborator

@bazarnov I've unassigned this issue from you pending completion of #11334

Ok, feel free to assign it back, once it's finished.

@igrankova igrankova added the Epic label Jun 27, 2022
@misteryeo
Copy link
Contributor Author

Issue was linked to Harvestr Discovery: Source Shopify in GA

@bazarnov bazarnov self-assigned this Oct 10, 2022
@bazarnov bazarnov changed the title [EPIC] Shopify Source to Beta [EPIC] Shopify Source to GA Oct 10, 2022
@bazarnov bazarnov changed the title [EPIC] Shopify Source to GA [EPIC] Shopify Source to Beta Oct 10, 2022
@YowanR YowanR changed the title [EPIC] Shopify Source to Beta [EPIC] Source Shopify to Beta Oct 11, 2022
@bazarnov bazarnov removed their assignment Oct 24, 2022
@bazarnov bazarnov changed the title [EPIC] Source Shopify to Beta [EPIC] Source Shopify to Cloud Jan 13, 2023
@bazarnov
Copy link
Collaborator

@YowanR all the issues, related to this Epic and all other small bugs that blocked us previously are resolved. The source-shopify is released as alpha to the Cloud and will remain, until moving to the beta is decided. We can now close this Epic as well.

@bazarnov
Copy link
Collaborator

The source-shopify has been released to Cloud as alpha. This Epic could be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Implementation in progress
Development

No branches or pull requests

7 participants