Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visually highlight required errors in cursor field and primary keys field #11084

Closed
Tracked by #12138
timroes opened this issue Mar 12, 2022 · 2 comments · Fixed by #11469
Closed
Tracked by #12138

Visually highlight required errors in cursor field and primary keys field #11084

timroes opened this issue Mar 12, 2022 · 2 comments · Fixed by #11469
Assignees
@jamakase
Labels
area/frontend Related to the Airbyte webapp type/bug Something isn't working

Comments

@timroes
Copy link
Collaborator

timroes commented Mar 12, 2022

Currently the cursor field and primary keys in the table don't have any visual error feedback that they are required. The form will just fail with a generic error leaving the user clueless what's happening.

screenshot-20220312-013142

Those fields should have clear visual highlights that they are required.
@timroes timroes added type/bug Something isn't working area/frontend labels Mar 12, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@timroes timroes mentioned this issue Mar 14, 2022
Closed
@misteryeo
Copy link
Contributor

Issue was linked to Harvestr Discovery: Default Sync Modes

@jamakase jamakase self-assigned this Mar 25, 2022
@jamakase jamakase mentioned this issue Mar 28, 2022
Merged
@timroes timroes mentioned this issue Apr 19, 2022
Closed
9 tasks
@timroes timroes added the area/frontend Related to the Airbyte webapp label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamakase jamakase

Labels
area/frontend Related to the Airbyte webapp type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error highlighting airbytehq/airbyte
4 participants
@timroes @jamakase @misteryeo @octavia-squidington-iii