Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX improvements for connector input fields #12204

Closed
Tracked by #12138 ...
edmundito opened this issue Apr 20, 2022 · 10 comments
Closed
Tracked by #12138 ...

UX improvements for connector input fields #12204

edmundito opened this issue Apr 20, 2022 · 10 comments
Assignees
Labels
area/frontend Related to the Airbyte webapp autoteam team/extensibility type/enhancement New feature or request

Comments

@edmundito
Copy link
Contributor

edmundito commented Apr 20, 2022

Update the connector input fields to align with the latest designs, which solve a number of issues related to placeholder text, description, examples, and errors.

Design:
https://www.figma.com/file/mFVUWYYjDm5zz6FFx8hTP6/FORMS-FIELDS?node-id=301%3A10567

Original Context

Tell us about the problem you're trying to solve

The way input fields are currently displayed should be improved. Here are a few issues seen:

  • It's not clear what fields are required and what fields are optional. We show * next to required fields, but we don't tell the user what the * means. Can we include the scope of this PRD in these designs?
  • Some descriptions are super long-- is there a better way to communicate this information? The field descriptions are passed from .yml files currently.
  • If the user tries to save a Source or Destination with missing required fields, the only feedback right now is that the field text turns red. We should do more (toast? message? something?)
  • Placeholder examples vs default values can be confusing
  • When submitting an invalid form, the error message just says invalid form instead of saying what field I missed

Examples

Forgot to fill out a required field?
image

Long windy description for the input field?
image

Is this a default value or a placeholder examples?
image

Describe the solution you’d like

Improve the input field component to resolve the issues described above. Specifics of how it should look like to be determined with design.

@edmundito edmundito added type/enhancement New feature or request area/frontend labels Apr 20, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@edmundito
Copy link
Contributor Author

edmundito commented Apr 27, 2022

Related: #10874 A proposal to replace the required fields with * with an Optional tag instead.

@edmundito
Copy link
Contributor Author

Design is validated, but work on how grouping advanced fields needs to be decided.

@edmundito
Copy link
Contributor Author

edmundito commented May 19, 2022

@edmundito edmundito changed the title UX improvements for connector UI generated input fields UX improvements for connector input fields Aug 11, 2022
@edmundito
Copy link
Contributor Author

Marked blocked by #15791 - However, this can be done simultaneously as long as the input components don't need to be modified.

@lmossman
Copy link
Contributor

lmossman commented Aug 29, 2022

@Upmitt I'm not seeing designs for invalid field errors in the FORMS FIELDS Figma that was linked on this ticket. Am I looking in the wrong place, or is this still something that needs to be designed?

Specifically, I think we need design to address this question from the Original Context above:

If the user tries to save a Source or Destination with missing required fields, the only feedback right now is that the field text turns red. We should do more (toast? message? something?)

@andyjih
Copy link
Contributor

andyjih commented Aug 30, 2022

@lmossman Made an asana task for @Upmitt to follow-up on error states.

@lmossman
Copy link
Contributor

Thanks! I talked about this with Tim briefly and for now I am going to just put the input error text in red next to the info icon if there is an input error. But a true design on this would be great!

@Upmitt
Copy link
Contributor

Upmitt commented Sep 1, 2022

Hi @lmossman ! You can check this file for the input states and error messages: https://www.figma.com/file/gMNRYVJav25pdsoxAyW7Qp/00_01_WEB-APP-LIBRARIES?node-id=2%3A396 - Let me know if you need clarifications or missing designs :)

@lmossman
Copy link
Contributor

Closed by #16152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp autoteam team/extensibility type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants