Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Google Analytics: enable incremental source acceptance test cases #12662

Closed
davydov-d opened this issue May 6, 2022 · 2 comments · Fixed by #13871
Closed

Source Google Analytics: enable incremental source acceptance test cases #12662

davydov-d opened this issue May 6, 2022 · 2 comments · Fixed by #13871
Assignees
@arsenlosenko
Labels
area/live-tests autoteam connectors/source/google-analytics-v4 team/connectors-python

Comments

@davydov-d
Copy link
Collaborator

davydov-d commented May 6, 2022 •
edited
Loading

Since GA source performs a 2-days look back search during the sync, incremental SAT case is not supported, therefore commented out.
The goal is to enable the test case after #12467 is implemented.
@pedroslopez pedroslopez mentioned this issue May 11, 2022
Merged
@pedroslopez
Copy link
Contributor

Hey @davydov-d , this should now be possible now that #12715 has been released.

@davydov-d
Copy link
Collaborator Author

Hey @davydov-d , this should now be possible now that #12715 has been released.

cc @sherifnada @misteryeo fyi, if you'd like to prioritize this issue - it is unblocked now

@lazebnyi lazebnyi assigned bazarnov and arsenlosenko and unassigned bazarnov Jun 10, 2022
@arsenlosenko arsenlosenko mentioned this issue Jun 17, 2022
Merged
14 tasks
@arsenlosenko arsenlosenko linked a pull request Jun 17, 2022 that will close this issue
Source Google Analytics: Add threshold_days option, uncomment statement for incremental tests #13871
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arsenlosenko arsenlosenko

Labels
area/live-tests autoteam connectors/source/google-analytics-v4 team/connectors-python
Projects
None yet
Milestone
No milestone
5 participants
@pedroslopez @davydov-d @arsenlosenko @bazarnov @octavia-squidington-iii