-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Resolve) Tech debt of the ConnectorForm #14250
Comments
cc @airbytehq/frontend |
current selection for Instead of storing this separately we can do the same thing the SAT is doing and search for the shared const field in each condition to determine the currently chosen path. This has the downside of breaking connectors which don't satisfy this SAT rule, but it seems justifiable in this case. The derived |
Last of the stacked PRs is in review and received feedback already, should be merged soon |
Approved, waiting for the code freeze |
Brainstomring issue about problem with the ServiceForm component. Please feel free to list all issues that should be addressed to make this component more stable and easier to maintain:
PatchInitialValuesWithWidgetConfig
hack)when
conditions on the found condition key (removeRevalidateOnValidationSchemaChange
hack)Pull out auth field hiding fromFormSection
to a higher level when generating from the spec which fields should be rendered.values.connectionConfiguration
plus flattened values are confusing (for a flattened form)Rethink-> extra issuedefault
behavior (should it be sending the value if the field is empty?), since it's working different depending on your field type atmThe text was updated successfully, but these errors were encountered: