Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additionalProperties: false from JDBC destination connectors #14550

Closed
3 tasks
grishick opened this issue Jul 8, 2022 · 0 comments · Fixed by #14618
Closed
3 tasks

Remove additionalProperties: false from JDBC destination connectors #14550

grishick opened this issue Jul 8, 2022 · 0 comments · Fixed by #14618
Assignees

Comments

@grishick
Copy link
Contributor

grishick commented Jul 8, 2022

Problem

As discovered in https://github.com/airbytehq/oncall/issues/289, a spec declaring "additionalProperties": false introduces the risk of accidental breaking changes. Specifically, when removing a property from the spec, existing connector configs will no longer be valid.

To make these upgrades/rollbacks smoother, we need to remove additionalProperties from connectors affected by these changes.

Action items

  • remove additionalProperties:false (or replace it with additionalProperties:true, whichever is the correct approach)
  • publish new versions of JDBC-based connectors
  • merge changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants