Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mode from component props where unecessary #17341

Closed
krishnaglick opened this issue Sep 28, 2022 · 1 comment · Fixed by #17808
Closed

Remove mode from component props where unecessary #17341

krishnaglick opened this issue Sep 28, 2022 · 1 comment · Fixed by #17808
Assignees
@teallarson
Labels
area/frontend Related to the Airbyte webapp team/platform-move

Comments

@krishnaglick
Copy link
Contributor

krishnaglick commented Sep 28, 2022 •
edited
Loading

The following components take mode as a prop. It should pull it out of the ConnectionForm service.

  • NormalizationField
  • FormCard
@krishnaglick krishnaglick changed the title Remove mode from NormalizationField props Remove mode from component props wher unecessary Sep 28, 2022
@krishnaglick krishnaglick changed the title Remove mode from component props wher unecessary Remove mode from component props where unecessary Sep 28, 2022
@salima-airbyte salima-airbyte added area/frontend Related to the Airbyte webapp and removed area/frontend labels Sep 28, 2022
@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@teallarson teallarson self-assigned this Oct 10, 2022
@teallarson teallarson mentioned this issue Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teallarson teallarson

Labels
area/frontend Related to the Airbyte webapp team/platform-move
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪟 🧹 Remove connection and mode prop drilling on connection view/edit pages airbytehq/airbyte
4 participants
@krishnaglick @teallarson @salima-airbyte @octavia-squidington-iv