Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate config menu modal from yaml connector spec block #17674

Closed
lmossman opened this issue Oct 6, 2022 · 2 comments · Fixed by #20385
Closed

Generate config menu modal from yaml connector spec block #17674

lmossman opened this issue Oct 6, 2022 · 2 comments · Fixed by #20385
Assignees

Comments

@lmossman
Copy link
Contributor

lmossman commented Oct 6, 2022

Tell us about the problem you're trying to solve

As described in the Tech Spec, something that is needed for the testing of a connector is a place to enter the "config" values, i.e. fill out the user inputs required to run the connector, as described in the connector spec.

Describe the solution you’d like

The frontend should pull the connector specification out of the yaml editor contents, and use that schema to generate an input form, similar to how connector forms are generated from connector specifications today (in the ConnectorForm component)

Many parts of the ConnectorForm can likely be reused for the purpose, but there will undoubtedly be some changes required to port it over to this other part of the application, which is where most of the complexity in this issue will be.

Acceptance Criteria

  • A button exists that opens the Config menu in a modal, which contains a form generated from the connector specification
  • When the connector specification is modified, the Config menu form is also updated
  • Changes to the config menu form update the connector builder state that is keeping track of the config
@lmossman
Copy link
Contributor Author

Please add your planning poker estimate with Zenhub @girarda

@flash1293
Copy link
Contributor

PR is ready to review, but stacked on top of the refactoring PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants