Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAT [strict_mode]: no basic_read.empty_streams #18221

Closed
alafanechere opened this issue Oct 20, 2022 · 0 comments · Fixed by #18425
Closed

SAT [strict_mode]: no basic_read.empty_streams #18221

alafanechere opened this issue Oct 20, 2022 · 0 comments · Fixed by #18425

Comments

@alafanechere
Copy link
Contributor

alafanechere commented Oct 20, 2022

Tell us about the problem you're trying to solve

We want to ensure a read operation is tested on all the streams exposed by a GA connector.
If this is not possible the connector maintainer must document why.

Describe the solution you’d like

In basic_read test SAT should fail if an empty_stream without a bypass_reasonis filled when strict_mode == strict.

  basic_read:
    - config_path: "secrets/config.json"
      configured_catalog_path: "integration_tests/configured_catalog.json"
      empty_streams: 
        - name: orders
          bypass_reason: "We don't have data for the orders stream on our sandbox account"

If a bypass_reason is filled SAT should log a warning.

@alafanechere alafanechere changed the title SAT: no basic_read.empty_streams when strict_mode == strict SAT [strict_mode]: no basic_read.empty_streams Oct 20, 2022
@alafanechere alafanechere self-assigned this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant