Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Amazon Ads: Deprecate report_wait_timeout and report_generation_max_retries fields #18948

Closed
girarda opened this issue Nov 4, 2022 · 0 comments · Fixed by #18985 or #19202
Closed

Comments

@girarda
Copy link
Contributor

girarda commented Nov 4, 2022

Tell us about the problem you're trying to solve

The report_wait_timeout and report_generation_max_retries configuration fields for the Amazon Ads source are used to configure how long the connector will wait for the report to be generated, and how often we'll retry in case of failures.

Both of these concerns are implementation details the users shouldn't have to worry about. Setting the wait timeout too low can lead to on-call issues due to the endpoint being intermittently slow.

Describe the solution you’d like

We should set the default values of these two fields to the max allowed and remove the fields from the spec. This will lower the mental load on the user, and will make the connector more resistant to the endpoint being slow at times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment