Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move getEntityTableData logic into the backend #19852

Closed
krishnaglick opened this issue Nov 28, 2022 · 2 comments
Closed

Move getEntityTableData logic into the backend #19852

krishnaglick opened this issue Nov 28, 2022 · 2 comments

Comments

@krishnaglick
Copy link
Contributor

The frontend has a method called getEntityTableData. It takes a set of sources or destinations, connections, and a source or destination definitions (which are a combined list of source or destination definitions along with their respective latest calls and data).
That's 4 API calls all to combine their data for frontend usage, as well as a lot of iteration. Moving all this logic into the backend lets us get that information in a single API call, and the data processing will be better places.

This should replace the sources/list or destinations/list calls for the sources list or destinations list pages.

@gosusnp
Copy link
Contributor

gosusnp commented Nov 30, 2022

Check feasibility and improvement on the backend beforehand to make sure we are tackling the right problem

@krishnaglick
Copy link
Contributor Author

Upon further investigation it looks like we can remove the list_by_workspace and list_latest calls from this logic completely. It's not worth the lift to move the code into the backend and with the other improvements made to the connections list endpoint I think things are in a good state with the removal of those calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants