Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SAT to Connector acceptance tests #21382

Closed
flash1293 opened this issue Jan 13, 2023 · 1 comment · Fixed by #21846
Closed

Rename SAT to Connector acceptance tests #21382

flash1293 opened this issue Jan 13, 2023 · 1 comment · Fixed by #21846
Assignees
Labels

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jan 13, 2023

After #20063 will be done, the spec part of the SATs are a very useful tool beyond only source connectors as they do basic checks about whether the spec is confirming to all documented requirements and will not cause problems in the UI as well.

The SATs are operating on the docker interface which means the spec test can be run without any changes against destination connector images. However, the name "source acceptance tests" is confusing in the context of destination connectors. As there are already multiple test suites for connectors which can be confusing for novices (e.g. standard destination tests), the source acceptance tests should be renamed to connector acceptance test to better reflect their more general nature. This should be done before spec acceptance tests are rolled out for destination connectors.

Acceptance criteria

@flash1293 flash1293 self-assigned this Jan 19, 2023
@sherifnada
Copy link
Contributor

Confirmation: @flash1293 talked w Greg and confirmed that it will be leveraged by destinations team, hence this refactor makes sense

@flash1293 flash1293 changed the title Rename SAT to CAT Rename SAT to Connector acceptance tests Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants