Source File-Secure: source-file-secure should depend on source-file python package instead of source-file docker image #26823
Labels
area/connectors
Connector related issues
connectors/source/file-secure
connectors/sources-api
from/connector-ops
type/enhancement
New feature or request
source-file-secure
is a variant ofsource-file
that enforces SSL.source-file-secure currently overrides source-file by installing
source-file
via the use of theFROM airbyte/source-file:0.3.9
instruction in its Dockerfile.It leads to the following clumsy imports to make sure the python execution can work inside a docker container or inside a classic python virtual env:
I believe we should rather install
source-file
insource-file-secure
via local pip dependencies declared in setup.py like here.It will simplify the dependency expression outside of the Docker context and allow us to build this connector with a standard dockerfile / dagger pipeline.
This will become more pressing when we'd want to get rid of Python connector's dockerfile and replace them by Dagger build pipeline with
airbyte-ci
.The text was updated successfully, but these errors were encountered: