Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab CE on premise instance issues. #3265

Closed
ameyw opened this issue May 6, 2021 · 6 comments · Fixed by #7108
Closed

Gitlab CE on premise instance issues. #3265

ameyw opened this issue May 6, 2021 · 6 comments · Fixed by #7108
Assignees
Labels
area/connectors Connector related issues community type/enhancement New feature or request

Comments

@ameyw
Copy link

ameyw commented May 6, 2021

Expected Behavior

Gitlab connector : Should allow adding urls which do not have gitlab.com . As on premise instances will have own custom domains

Current Behavior

Url which do not contain gitlab.com shows error due to validations

Logs

If applicable, please upload the logs from the failing operation. For sync jobs, you can download the full logs from the UI by going to the sync attempt page and clicking the download logs button at the top right of the logs display window.

Steps to Reproduce

1.Add title

  1. Add connector as gitlab
  2. Add a custom url

Severity of the bug for you

High

Airbyte Version

Foun

Connector Version (if applicable)

0.1.1

Additional context

Environment, version, integration...

┆Issue is synchronized with this Asana task by Unito

@ameyw ameyw added the type/bug Something isn't working label May 6, 2021
@marcosmarxm marcosmarxm added the area/connectors Connector related issues label May 6, 2021
@sherifnada sherifnada added type/enhancement New feature or request and removed type/bug Something isn't working labels May 6, 2021
@sherifnada
Copy link
Contributor

@ameyw thanks for creating the issue! I have some questions about this.

Is the Gitlab on-prem API guaranteed to be the same as the cloud one? Which version of GL / the GL API are you running?

@ameyw
Copy link
Author

ameyw commented May 10, 2021

@sherifnada The CE and EE versions have similar api. we are currently on 13.9. Since the Cloud and on-prem have same documentation i suppose the structure remains same. GL API version is v4. Attached image for reference.

image

@ameyw
Copy link
Author

ameyw commented May 25, 2021

Is this issue resolved ..

@sherifnada
Copy link
Contributor

@ameyw we're currently rewriting the Gitlab connector to move away from the Singer-based one. Once that is done it should be fairly straightforward to add this functionality. Would you be open to creating a PR to support it?

@sherifnada
Copy link
Contributor

next step for this issue would be to:

  1. allow arbitrary URLs like in GitLab source - not possible to configure self managed instance #6453
  2. inform users in the docs that this is chiefly made to work with hosted Gitlab but could work with the "appropriate version" of self-hosted (we should definitely be more specific than "appropriate version" if possible)

@Zirochkaa
Copy link
Contributor

This ticket is blocked on #6822.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues community type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants