Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow annotating and separating advanced options for each connector config in the UI #3681

Closed
sherifnada opened this issue May 28, 2021 · 4 comments
Labels
area/frontend Related to the Airbyte webapp autoteam type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

sherifnada commented May 28, 2021

Tell us about the problem you're trying to solve

There are a few options on connectors which 95% of users don't need. For example, the freshdesk connector exposes an option to specify how many requests per minute the connector should make i.e: self throttling. the purpose of this option is to avoid hogging all the API bandwidth if the token is shared by many users:
Screen Shot 2021-05-27 at 5 23 41 PM

While this is useful, most users probably don't care about this option. So showing it to them is a little confusing.

Describe the solution you’d like

I would like to suggest two improvements here:

We should have a separate, collapsible section for advanced properties. If a property in spec.json has the advanced: true annotation it should be displayed in the advanced options section.

It would be great to have an expandable section like this:

image

(different app but you get the idea)

@sherifnada sherifnada added type/enhancement New feature or request area/frontend labels May 28, 2021
@cgardens
Copy link
Contributor

For 1. Is your feeling that the asterisk for required fields isn't clear enough?

@jamakase
Copy link
Contributor

jamakase commented Nov 2, 2021

@sherifnada I do not think that adding advance flag is a good idea as it looks like monkey patching for me. Should we better try to split all our settings into more sections? Like it is done for IntellIj db connection?

Then we could add some sort of an area tag within our config. So let's say instead of 1 big form it will be a form with numerous tabs:

  1. common
  2. auth ( some auth specific props could go here like setting up tokens and etc or oauth )
  3. advanced
  4. ...something else? Like any additional tabs that we may need for cloud: setting up github path where config could be stored and etc etc etc

@sherifnada
Copy link
Contributor Author

circling back to advocate for the importance of this issue:

right now I’m very averse to exposing things like this because for 99% of users they’re not relevant and will just cause confusion/a worse impression of the polish of the product. But there is objective value in exposing this kind of configuration, even as an intermediate state before doing something more intelligent inside the connector.

Having this ticket would relieve us from having to make hard tradeoffs between serving different personas

@timroes
Copy link
Collaborator

timroes commented Jun 29, 2022

Closing in favor of #14247

@timroes timroes closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp autoteam type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants