Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: Allow specifying aribtrary keyword args to an outgoing HTTP request #4489

Closed
sherifnada opened this issue Jul 2, 2021 · 0 comments · Fixed by #4493
Closed

CDK: Allow specifying aribtrary keyword args to an outgoing HTTP request #4489

sherifnada opened this issue Jul 2, 2021 · 0 comments · Fixed by #4493
Labels
CDK Connector Development Kit type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

A user may want to set extra options on the request.send method such as auth, cert, or others.

Describe the solution you’d like

I want to expose a method on HttpStream as follows:

def request_kwargs(self) -> Mapping[str, Any]: 
    """  
    returns a mapping of keyword arguments to be used when creating the HTTP request. 
    See https://docs.python-requests.org/en/master/user/advanced/ for various options which can be returned from 
    this method. 

    any args returned from this method will be flattened into the outgoing request via something 
    like `requests.get(url, **self.request_kwargs())`. 
    """

Describe the alternative you’ve considered or used

Use the Stream class directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant