Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source GitHub: Check command relies on Projects stream, which fails if projects are not enabled for specified repositories #5534

Closed
cjwooo opened this issue Aug 19, 2021 · 4 comments · Fixed by #5788
Assignees
Labels

Comments

@cjwooo
Copy link
Contributor

cjwooo commented Aug 19, 2021

Enviroment

  • Airbyte version: no matter
  • OS Version / Instance: no matter
  • Deployment: no matter
  • Source Connector and version: GitHub Source
  • Destination Connector and version:
  • Severity: High
  • Step where error happened: Setup new connection

Current Behavior

When I try setting up a GitHub source with a repository that doesn't have projects enabled, or my token doesn't have enough privileges, the check command fails because the GitHub API returns the corresponding error codes. https://docs.github.com/en/rest/reference/projects#list-repository-projects

I don't think the source should use a stream that depends on such conditions to validate the source config.

Expected Behavior

GitHub source should validate a config even these stream-specific conditions are not met.

Logs

If applicable, please upload the logs from the failing operation.
For sync jobs, you can download the full logs from the UI by going to the sync attempt page and
clicking the download logs button at the top right of the logs display window.

LOG

replace this with
your long log
output here

Steps to Reproduce

Are you willing to submit a PR?

Yes

@cjwooo cjwooo added the type/bug Something isn't working label Aug 19, 2021
@marcosmarxm
Copy link
Member

Thanks for opening this @cjwooo. Do you need assistance to do the PR change?

@sherifnada
Copy link
Contributor

@cjwooo let us know if we can help with doing this -- we can implement on our side if needed

@sherifnada sherifnada added this to the Connectors, September 3rd milestone Aug 31, 2021
@sherifnada sherifnada added the area/connectors Connector related issues label Aug 31, 2021
@sherifnada
Copy link
Contributor

@cjwooo taking this into our sprint, let me know if you have a PR you'd like to submit

@yevhenii-ldv
Copy link
Contributor

@cjwooo We just merged this fix into master and released a new version of the connector (PR link here).

Upgrade your connector to version 0.1.9 and get started. To upgrade your connector version, go to the admin panel in the left hand side of the UI, find this connector in the list, and input the latest connector version.

Please let us know if you have any further questions.
Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants