Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate connector definition update from the config import #5684

Closed
tuliren opened this issue Aug 26, 2021 · 1 comment · Fixed by #5965
Closed

Separate connector definition update from the config import #5684

tuliren opened this issue Aug 26, 2021 · 1 comment · Fixed by #5965
Labels
type/enhancement New feature or request

Comments

@tuliren
Copy link
Contributor

tuliren commented Aug 26, 2021

Tell us about the problem you're trying to solve

  • Currently we automatically update connector definition when a config archive is imported.
  • This makes the code very complicated. Also we probably want to update the connector definitions more frequently.

Describe the solution you’d like

  • Move the update logic out of the config import process.
  • Maybe implement automatic update in the server.

Describe the alternative you’ve considered or used

N/A

Additional context

N/A

Are you willing to submit a PR?

Yes.

@tuliren
Copy link
Contributor Author

tuliren commented Aug 31, 2021

Can use the new DatabaseConfigPersistence#loadData method introduced in #5678 to update the connector definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant