Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Snowflake destination normalization to accept any date-time format. #5713

Closed
Tracked by #5439
sherifnada opened this issue Aug 27, 2021 · 0 comments · Fixed by #6052
Closed
Tracked by #5439

Fix Snowflake destination normalization to accept any date-time format. #5713

sherifnada opened this issue Aug 27, 2021 · 0 comments · Fixed by #6052

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Aug 27, 2021

implementation hints

You can probably do this without being completely blocked on the acceptance test piece above.

  1. Find the diff between json-schema's date and date-time formats and those accepted by Snowflake for the TIMESTAMP type
  2. Write a snowflake-SQL compliant CASE statement which converts ISO8601 date-time formats not supported by Snowflake into a format that is supported (usually you'll need to add : or something similar, the value of the date fundamentally should not change, it should only be a format change). If it helps, use the snowflake login in lastpass to iterate on this statement in the snowflake UI until you get this statement right.
  3. Add a DBT macro to use the CASE statement you created above (ask Chris for help if needed)
  4. Add any needed normalization integration tests (ask chris for guidance on which tests are needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants