Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Gitlab: support oauth #6264

Closed
sherifnada opened this issue Sep 19, 2021 · 3 comments
Closed

Source Gitlab: support oauth #6264

sherifnada opened this issue Sep 19, 2021 · 3 comments

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret
  2. Oauth properties are annotated properly. See this PR for an example
@YowanR
Copy link
Contributor

YowanR commented Nov 16, 2022

@igrankova @ycherniaiev Can you confirm that this work was blocked on Single Refresh Token? Thanks

@igrankova
Copy link
Contributor

@YowanR
I don't see it's blocked. We have the public app and creds, everything looks fine from our side.
Public App
Client and Secret Lastpass name: GitLab Public Oauth Developer Application
Account LastPass name: gitlab.com
OAuth docs
Let me know if I didn't get the question.
cc @ycherniaiev

@davydov-d davydov-d self-assigned this Dec 1, 2022
@davydov-d
Copy link
Collaborator

Closing it as a duplicate of #7480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants