Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source MSSQL: Implement SSH bastion for acceptance/integration tests #6502

Closed
alexandr-shegeda opened this issue Sep 28, 2021 · 0 comments · Fixed by #6608
Closed

🎉 Source MSSQL: Implement SSH bastion for acceptance/integration tests #6502

alexandr-shegeda opened this issue Sep 28, 2021 · 0 comments · Fixed by #6608

Comments

@alexandr-shegeda
Copy link
Contributor

Tell us about the problem you're trying to solve

Improve the process of acceptance testing by allowing doing acceptance/integration testing using a bastion running in a docker container. Right now we have a dedicated host in AWS that we use.

Why do we care?

  1. We'd rather not maintain the bastion infra if we don't have to
  2. It means that the tests require secrets as an input which adds a bit more friction. If we use docker that would not be necessary.
  3. It requires having a static instance of the database we trying to test running! Because the bastion is static it also needs to be forwarding to some database in our VPC so we need a statically running db as well. This limits the tests we can right and means we're paying for and maintaining a database for no good reason. Ideally we could spin up dbs and bastion all in docker!

Describe the alternative you’ve considered or used

Example of adding SSH bastion to Postgres source/destination

Note that this PR has way more logic in them than what you'll need to implement for a single connector because they add common helpers and shared libraries and docs

@alexandr-shegeda alexandr-shegeda added the type/enhancement New feature or request label Sep 28, 2021
@alexandr-shegeda alexandr-shegeda changed the title Source MSSQL: Implement SSH bastion for acceptance/integration tests 🎉 Source MSSQL: Implement SSH bastion for acceptance/integration tests Sep 28, 2021
@alexandr-shegeda alexandr-shegeda added area/connectors Connector related issues lang/java priority/high High priority labels Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants