Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source SurveyMonkey: support oauth #7483

Closed
igrankova opened this issue Oct 29, 2021 · 1 comment
Closed

Source SurveyMonkey: support oauth #7483

igrankova opened this issue Oct 29, 2021 · 1 comment

Comments

@igrankova
Copy link
Contributor

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:

If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret in a backwards compatible manner
  2. Oauth properties are annotated properly. See this PR for an example
@igrankova igrankova added area/connectors Connector related issues area/oauth labels Oct 29, 2021
@igrankova igrankova changed the title Source SurveyMonkey : support oauth Source SurveyMonkey: support oauth Oct 29, 2021
@bazarnov bazarnov self-assigned this Nov 4, 2021
@bazarnov
Copy link
Collaborator

bazarnov commented Nov 4, 2021

The Source SurveyMonkey is already extended with OAuth2.0 support in Python part, as well as in Java server part. It works since 0.1.2, and with current 0.1.3.

This issue should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

No branches or pull requests

2 participants