From 3e83b1df546b6ed06b0be1c0ee7112a6191dc993 Mon Sep 17 00:00:00 2001 From: bgopikrishna Date: Tue, 18 Oct 2022 23:19:34 +0530 Subject: [PATCH] removed unused props clickable, wasActive from button component --- airbyte-webapp/src/components/ui/Button/Button.tsx | 2 -- airbyte-webapp/src/components/ui/Button/types.tsx | 2 -- .../pages/ConnectorsPage/components/UpgradeAllButton.tsx | 1 - .../ConnectorForm/components/Sections/auth/GoogleAuthButton.tsx | 1 - .../Connector/RequestConnectorModal/RequestConnectorModal.tsx | 1 - 5 files changed, 7 deletions(-) diff --git a/airbyte-webapp/src/components/ui/Button/Button.tsx b/airbyte-webapp/src/components/ui/Button/Button.tsx index 10d375a0294f..4a5aaeee536f 100644 --- a/airbyte-webapp/src/components/ui/Button/Button.tsx +++ b/airbyte-webapp/src/components/ui/Button/Button.tsx @@ -14,10 +14,8 @@ export const Button = React.forwardRef((props, r variant = "primary", children, className, - clickable, icon, isLoading, - wasActive, width, disabled, ...buttonProps diff --git a/airbyte-webapp/src/components/ui/Button/types.tsx b/airbyte-webapp/src/components/ui/Button/types.tsx index 09e46b431047..fe0c61be8aa5 100644 --- a/airbyte-webapp/src/components/ui/Button/types.tsx +++ b/airbyte-webapp/src/components/ui/Button/types.tsx @@ -4,13 +4,11 @@ type ButtonSize = "xs" | "sm" | "lg"; type ButtonVariant = "primary" | "secondary" | "danger" | "light" | "clear" | "dark"; export interface ButtonProps extends React.ButtonHTMLAttributes { - clickable?: boolean; full?: boolean; icon?: React.ReactElement; iconPosition?: "left" | "right"; isLoading?: boolean; size?: ButtonSize; variant?: ButtonVariant; - wasActive?: boolean; width?: number; } diff --git a/airbyte-webapp/src/pages/SettingsPage/pages/ConnectorsPage/components/UpgradeAllButton.tsx b/airbyte-webapp/src/pages/SettingsPage/pages/ConnectorsPage/components/UpgradeAllButton.tsx index 3f76768c2778..9c6e1a990917 100644 --- a/airbyte-webapp/src/pages/SettingsPage/pages/ConnectorsPage/components/UpgradeAllButton.tsx +++ b/airbyte-webapp/src/pages/SettingsPage/pages/ConnectorsPage/components/UpgradeAllButton.tsx @@ -50,7 +50,6 @@ const UpgradeAllButton: React.FC = ({ onUpdate, isLoading, className={styles.updateButton} onClick={onUpdate} isLoading={isLoading} - wasActive={hasSuccess} icon={hasSuccess ? undefined : } > {hasSuccess ? : } diff --git a/airbyte-webapp/src/views/Connector/ConnectorForm/components/Sections/auth/GoogleAuthButton.tsx b/airbyte-webapp/src/views/Connector/ConnectorForm/components/Sections/auth/GoogleAuthButton.tsx index dd85acdc1229..e10e2d51a128 100644 --- a/airbyte-webapp/src/views/Connector/ConnectorForm/components/Sections/auth/GoogleAuthButton.tsx +++ b/airbyte-webapp/src/views/Connector/ConnectorForm/components/Sections/auth/GoogleAuthButton.tsx @@ -17,7 +17,6 @@ const StyledButton = styled.button` line-height: 15px; outline: none; padding: 0 10px 0 0; - pointer-events: ${(props) => (props.wasActive && !props.clickable ? "none" : "all")}; text-align: center; text-decoration: none; width: ${(props) => (props.full ? "100%" : "auto")}; diff --git a/airbyte-webapp/src/views/Connector/RequestConnectorModal/RequestConnectorModal.tsx b/airbyte-webapp/src/views/Connector/RequestConnectorModal/RequestConnectorModal.tsx index ce41bad36793..bce087e17bbc 100644 --- a/airbyte-webapp/src/views/Connector/RequestConnectorModal/RequestConnectorModal.tsx +++ b/airbyte-webapp/src/views/Connector/RequestConnectorModal/RequestConnectorModal.tsx @@ -167,7 +167,6 @@ const RequestConnectorModal: React.FC = ({ className={styles.requestButton} // type="submit" onClick={handleSubmit} - wasActive={hasFeedback} > {hasFeedback ? : }