-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data types update: Implement protocol message downgrade path #19909
Merged
edgao
merged 30 commits into
edgao/data_type_protocol_migration_upgrade
from
edgao/data_type_protocol_migration_downgrade
Dec 21, 2022
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
34c8d48
rough skeleton for passing catalog into migration
edgao 8c74dcc
basic test
edgao d02f83f
more scaffolding
edgao 892458a
basic implementation
edgao 6270c3f
add primitives test
edgao 1566b7f
add in other tests (nested fields currently failing)
edgao d52a05e
add formats
edgao ee4bc24
impleent oneOf handling
edgao 46a927d
formatting
edgao 4e9fc9c
oneOf handling
edgao a6e92b8
better tests
edgao c6f5382
comments + organization
edgao f2c036a
progress
edgao c2ba52f
basic test case
edgao 5af14ef
downgrade objects, ish
edgao afc860c
basic array implementation
edgao 3ef91a9
handle numeric failure
edgao 534b277
test for new type
edgao 6c3f9e1
handle array items
edgao ee4ee4b
empty schema handling
edgao c7cce8d
first pass at oneof handling
edgao 17265c5
add more tests+handling
edgao 3f0bddd
more tests
edgao 3c4af5c
comments
edgao 6d39258
add empty oneof test case
edgao b5af0e9
format + reorganize
edgao 8f60d66
more reorganize
edgao 0bd1724
fix name
edgao 8971f60
also downgrade binary data
edgao 8408f36
only import vnull
edgao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this dependency because the downgrade migration needs to be able to test whether a record (or part of a record) matches a schema (or subschema).