From 57fc9d18f3afc300efd82b7f6428c1e651833e24 Mon Sep 17 00:00:00 2001 From: Julian Date: Mon, 5 Dec 2022 14:07:29 +0100 Subject: [PATCH 1/3] Update 5-incremental-reads.md in response of Issue #20047 Added the suggested solution from issuer. --- .../config-based/tutorial/5-incremental-reads.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/connector-development/config-based/tutorial/5-incremental-reads.md b/docs/connector-development/config-based/tutorial/5-incremental-reads.md index 15cbe1cb692b..67682e9c7bd5 100644 --- a/docs/connector-development/config-based/tutorial/5-incremental-reads.md +++ b/docs/connector-development/config-based/tutorial/5-incremental-reads.md @@ -103,7 +103,7 @@ definitions: datetime_format: "%Y-%m-%d" end_datetime: datetime: "{{ now_utc() }}" - datetime_format: "%Y-%m-%d %H:%M:%S.%f" + datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00" step: "1d" datetime_format: "%Y-%m-%d" cursor_field: "{{ options['stream_cursor_field'] }}" From 0f35da5d2cf7e48dd61ce14171eb797f65de97cc Mon Sep 17 00:00:00 2001 From: Julian Date: Mon, 5 Dec 2022 14:13:36 +0100 Subject: [PATCH 2/3] Updated 5-incremental-reads.md #2 Appended the suggested +00:00 into another occurence. Datetime format now corresponds to standards defined in ISO-8601. --- .../config-based/tutorial/5-incremental-reads.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/connector-development/config-based/tutorial/5-incremental-reads.md b/docs/connector-development/config-based/tutorial/5-incremental-reads.md index 67682e9c7bd5..f91f76127386 100644 --- a/docs/connector-development/config-based/tutorial/5-incremental-reads.md +++ b/docs/connector-development/config-based/tutorial/5-incremental-reads.md @@ -181,7 +181,7 @@ definitions: datetime_format: "%Y-%m-%d" end_datetime: datetime: "{{ now_utc() }}" - datetime_format: "%Y-%m-%d %H:%M:%S.%f" + datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00" step: "1d" datetime_format: "%Y-%m-%d" cursor_field: "{{ options['stream_cursor_field'] }}" From 7265962c796659fac87665cf8b7035bf858581db Mon Sep 17 00:00:00 2001 From: juweins Date: Mon, 5 Dec 2022 17:35:03 +0100 Subject: [PATCH 3/3] Fix: Low Code Connector tutorial yaml #20071 --- CONTRIBUTORS.md | 1 + .../tutorial/3-connecting-to-the-API-source.md | 8 ++++---- .../config-based/tutorial/5-incremental-reads.md | 8 ++++---- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 22d1c26721d1..796352ea1bff 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -61,6 +61,7 @@ * [jonathan-duval](https://github.com/jonathan-duval) * [jonstacks](https://github.com/jonstacks) * [jrhizor](https://github.com/jrhizor) +* [juweins](https://github.com/juweins) * [keu](https://github.com/keu) * [lazebnyi](https://github.com/lazebnyi) * [lizdeika](https://github.com/lizdeika) diff --git a/docs/connector-development/config-based/tutorial/3-connecting-to-the-API-source.md b/docs/connector-development/config-based/tutorial/3-connecting-to-the-API-source.md index 7007b910476d..ad05a6c84d10 100644 --- a/docs/connector-development/config-based/tutorial/3-connecting-to-the-API-source.md +++ b/docs/connector-development/config-based/tutorial/3-connecting-to-the-API-source.md @@ -22,8 +22,8 @@ Let's populate the specification (`spec`) and the configuration (`secrets/config ```yaml spec: - documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi - connectionSpecification: + documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi + connection_specification: $schema: http://json-schema.org/draft-07/schema# title: exchangeratesapi.io Source Spec type: object @@ -170,8 +170,8 @@ check: stream_names: - "rates" spec: - documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi - connectionSpecification: + documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi + connection_specification: $schema: http://json-schema.org/draft-07/schema# title: exchangeratesapi.io Source Spec type: object diff --git a/docs/connector-development/config-based/tutorial/5-incremental-reads.md b/docs/connector-development/config-based/tutorial/5-incremental-reads.md index f91f76127386..dfabeff150d3 100644 --- a/docs/connector-development/config-based/tutorial/5-incremental-reads.md +++ b/docs/connector-development/config-based/tutorial/5-incremental-reads.md @@ -11,8 +11,8 @@ First we'll update the spec block in `source_exchange_rates_tutorial/exchange_ra ```yaml spec: - documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi - connectionSpecification: + documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi + connection_specification: $schema: http://json-schema.org/draft-07/schema# title: exchangeratesapi.io Source Spec type: object @@ -210,8 +210,8 @@ check: stream_names: - "rates" spec: - documentationUrl: https://docs.airbyte.io/integrations/sources/exchangeratesapi - connectionSpecification: + documentation_url: https://docs.airbyte.io/integrations/sources/exchangeratesapi + connection_specification: $schema: http://json-schema.org/draft-07/schema# title: exchangeratesapi.io Source Spec type: object