From f76199ea78e2256c664cec1a957f24ce3e1b4f5d Mon Sep 17 00:00:00 2001 From: satish Date: Mon, 31 Jan 2022 12:27:34 +0530 Subject: [PATCH 1/2] Kafka Source Destination issue Fixed :Not able to read kafka config "sasl_jaas_config" and "sasl_mechanism" throwing null pointer exception. --- .../init/src/main/resources/seed/destination_definitions.yaml | 2 +- airbyte-integrations/connectors/destination-kafka/Dockerfile | 2 +- .../destination/kafka/KafkaDestinationConfig.java | 4 ++-- docs/integrations/destinations/kafka.md | 1 + 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml index 7bd1fb3b4888..fa57d578c9fb 100644 --- a/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/destination_definitions.yaml @@ -72,7 +72,7 @@ - name: Kafka destinationDefinitionId: 9f760101-60ae-462f-9ee6-b7a9dafd454d dockerRepository: airbyte/destination-kafka - dockerImageTag: 0.1.3 + dockerImageTag: 0.1.4 documentationUrl: https://docs.airbyte.io/integrations/destinations/kafka icon: kafka.svg - name: Kinesis diff --git a/airbyte-integrations/connectors/destination-kafka/Dockerfile b/airbyte-integrations/connectors/destination-kafka/Dockerfile index e82d36c9fa39..05023f06edfc 100644 --- a/airbyte-integrations/connectors/destination-kafka/Dockerfile +++ b/airbyte-integrations/connectors/destination-kafka/Dockerfile @@ -16,5 +16,5 @@ ENV APPLICATION destination-kafka COPY --from=build /airbyte /airbyte -LABEL io.airbyte.version=0.1.3 +LABEL io.airbyte.version=0.1.4 LABEL io.airbyte.name=airbyte/destination-kafka diff --git a/airbyte-integrations/connectors/destination-kafka/src/main/java/io/airbyte/integrations/destination/kafka/KafkaDestinationConfig.java b/airbyte-integrations/connectors/destination-kafka/src/main/java/io/airbyte/integrations/destination/kafka/KafkaDestinationConfig.java index 51a08faeb524..6c28fcc3bd5c 100644 --- a/airbyte-integrations/connectors/destination-kafka/src/main/java/io/airbyte/integrations/destination/kafka/KafkaDestinationConfig.java +++ b/airbyte-integrations/connectors/destination-kafka/src/main/java/io/airbyte/integrations/destination/kafka/KafkaDestinationConfig.java @@ -86,8 +86,8 @@ private Map propertiesByProtocol(final JsonNode config) { switch (protocol) { case PLAINTEXT -> {} case SASL_SSL, SASL_PLAINTEXT -> { - builder.put(SaslConfigs.SASL_JAAS_CONFIG, config.get("sasl_jaas_config").asText()); - builder.put(SaslConfigs.SASL_MECHANISM, config.get("sasl_mechanism").asText()); + builder.put(SaslConfigs.SASL_JAAS_CONFIG, protocolConfig.get("sasl_jaas_config").asText()); + builder.put(SaslConfigs.SASL_MECHANISM, protocolConfig.get("sasl_mechanism").asText()); } default -> throw new RuntimeException("Unexpected Kafka protocol: " + Jsons.serialize(protocol)); } diff --git a/docs/integrations/destinations/kafka.md b/docs/integrations/destinations/kafka.md index 98539e5a908c..893a9c710fd7 100644 --- a/docs/integrations/destinations/kafka.md +++ b/docs/integrations/destinations/kafka.md @@ -98,6 +98,7 @@ _NOTE_: Some configurations for SSL are not available yet. | Version | Date | Pull Request | Subject | | :--- | :--- | :--- | :--- | +| 0.1.4 | 2022-01-31 | [\#8865](https://github.com/airbytehq/airbyte/pull/8865) | Fix SASL config read issue | | 0.1.3 | 2021-12-30 | [\#8809](https://github.com/airbytehq/airbyte/pull/8809) | Update connector fields title/description | | 0.1.2 | 2021-09-14 | [\#6040](https://github.com/airbytehq/airbyte/pull/6040) | Change spec.json and config parser | | 0.1.1 | 2021-07-30 | [\#5125](https://github.com/airbytehq/airbyte/pull/5125) | Enable `additionalPropertities` in spec.json | From ef50d050d7db3339a50855d4d08987385f5aa85d Mon Sep 17 00:00:00 2001 From: satish Date: Mon, 31 Jan 2022 12:33:42 +0530 Subject: [PATCH 2/2] Kafka Source Destination issue Fixed :Not able to read kafka config "sasl_jaas_config" and "sasl_mechanism" throwing null pointer exception. --- docs/integrations/destinations/kafka.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/integrations/destinations/kafka.md b/docs/integrations/destinations/kafka.md index 893a9c710fd7..93edc138ee56 100644 --- a/docs/integrations/destinations/kafka.md +++ b/docs/integrations/destinations/kafka.md @@ -98,7 +98,7 @@ _NOTE_: Some configurations for SSL are not available yet. | Version | Date | Pull Request | Subject | | :--- | :--- | :--- | :--- | -| 0.1.4 | 2022-01-31 | [\#8865](https://github.com/airbytehq/airbyte/pull/8865) | Fix SASL config read issue | +| 0.1.4 | 2022-01-31 | [\#9905](https://github.com/airbytehq/airbyte/pull/9905) | Fix SASL config read issue | | 0.1.3 | 2021-12-30 | [\#8809](https://github.com/airbytehq/airbyte/pull/8809) | Update connector fields title/description | | 0.1.2 | 2021-09-14 | [\#6040](https://github.com/airbytehq/airbyte/pull/6040) | Change spec.json and config parser | | 0.1.1 | 2021-07-30 | [\#5125](https://github.com/airbytehq/airbyte/pull/5125) | Enable `additionalPropertities` in spec.json |