Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Remove vendored json minifier #1140

Closed
datapythonista opened this issue Mar 14, 2022 · 2 comments
Closed

CLN: Remove vendored json minifier #1140

datapythonista opened this issue Mar 14, 2022 · 2 comments

Comments

@datapythonista
Copy link
Member

xref #1139

I didn't check in detail, but I guess the vendored json minifier in asv/extern/minify_json.py can be replaced with the next approach using simply the json standard library module: https://stackoverflow.com/a/33233406/711705
@datapythonista datapythonista mentioned this issue Apr 5, 2022
Closed
@fangchenli
Copy link
Contributor

We also need to be able to read json file with comments, so still need the minify_json. We could add support for writing config in pyproject.toml and deprecated the existing json config file.

@HaoZeke
Copy link
Member

HaoZeke commented Mar 3, 2023

This is completed in #1234

@HaoZeke HaoZeke closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HaoZeke @fangchenli @datapythonista