Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection does not work with all OS X text Services #2662

Closed
lastobelus opened this issue Sep 9, 2015 · 5 comments
Closed

Selection does not work with all OS X text Services #2662

lastobelus opened this issue Sep 9, 2015 · 5 comments

Comments

@lastobelus
Copy link

All OS X text services that act on a selection are broken, and the selected text is not passed to the service. I haven't dug into the mechanics of this, but it is the cause of #2446.

OS X Text services are a very popular way of adding functionality across editors. See for example Markdown Service Tools, SearchLink

Also see HappenApps/Quiver#163

@lastobelus
Copy link
Author

Also see markpluslabs/react-markplus#30

@nightwing
Copy link
Member

This happens because Ace creates dom nodes only for the visible part of the text, and doesn't create browser selection.
We could put selected text into the textarea if the selection is small (e.g < 1000 characters) but doing that for larger selections would make editor very slow.

@lastobelus
Copy link
Author

handling small selections would satisfy the majority of needs I think.

@lastobelus
Copy link
Author

the only exception would be using searchlink to switch a whole document's links between inline & reference style.

@nightwing
Copy link
Member

#3635 fixes the issue for small selections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants