-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code adaptation #5
Comments
Since I initially released this library over two years ago, I’m sure the code could benefit from the best practices you've suggested. Feel free to proceed with those cosmetic changes and I'll be happy to merge them in. |
@akacdev You are now welcome to take a look at my changes and try out the new version for yourself |
There is a minor issue where the fire-and-forget method call in |
Would you accept a pull request with which I bring more structure to the project?
_clientWebSocket
instead ofprivate ClientWebSocket WebSocket
.StartAsync
.That would of course be a breaking change...
The text was updated successfully, but these errors were encountered: