From 1acede5f499e786d1b996d21d2152101b741e5da Mon Sep 17 00:00:00 2001 From: LHearen Date: Wed, 14 Nov 2018 14:25:49 +0800 Subject: [PATCH 1/4] Fix typos in readme.md * Update readme.md Just fix some typos * Fix typo --- readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readme.md b/readme.md index bd8cce6..37a4d56 100644 --- a/readme.md +++ b/readme.md @@ -23,7 +23,7 @@ Pennywise opens any website or media in a **small floating window that remains o * **Resize and place** it anywhere * **Shortcuts** to make you more productive * Lets you **multitask** while you work -* **Opensource** licensed under MIT +* **Open source** licensed under MIT * **Lean** small resource footprint, minimal User Interface. * **Cross-platform** works on MacOS, Windows and Linux @@ -39,7 +39,7 @@ brew cask install pennywise ## Usecases -> Here is the list of some of the possible usecases off the top of my head +> Here is the list of some of the possible use cases off the top of my head * Use it as a floating window for your calendar/checklist/assigned-tickets etc * Watching tutorial while you code? Open the video in Pennywise and keep it in front of you From 9b5bf699503fcd07637c8fa94c3f4b05a1fcc1ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1nos=20Orcsik?= Date: Thu, 15 Nov 2018 15:46:55 +0100 Subject: [PATCH 2/4] Fix typo in componentWillUnmount (#83) --- src/browser.js | 2 +- src/components/nav-bar/index.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/browser.js b/src/browser.js index 8adfc7f..2decc6a 100644 --- a/src/browser.js +++ b/src/browser.js @@ -26,7 +26,7 @@ class Browser extends React.Component { ipcRenderer.on('embedVideos.set', this.onembedVideosSet); } - componentWillUnMount() { + componentWillUnmount() { ipcRenderer.removeEventListener('embedVideos.set', this.onembedVideosSet); } diff --git a/src/components/nav-bar/index.js b/src/components/nav-bar/index.js index d406953..676efbd 100644 --- a/src/components/nav-bar/index.js +++ b/src/components/nav-bar/index.js @@ -49,7 +49,7 @@ class NavBar extends Component { ipcRenderer.on('nav.focus', this.focusUrlInput); } - componentWillUnMount() { + componentWillUnmount() { ipcRenderer.removeListener('nav.focus', this.focusUrlInput); } From 9754946cc58b48124ec1fa5063ae4d058611a094 Mon Sep 17 00:00:00 2001 From: HyunmoAhn Date: Mon, 26 Nov 2018 18:55:55 +0900 Subject: [PATCH 3/4] Typo Fix about release link. (#86) --- public/menu.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/menu.js b/public/menu.js index 8620e63..3f8ff06 100644 --- a/public/menu.js +++ b/public/menu.js @@ -184,7 +184,7 @@ function setMainMenu(mainWindow) { { label: `About Version`, click() { - shell.openExternal(`https://github.com/kamranahmedse/pennywise/releases/tag/${appVersion}`); + shell.openExternal(`https://github.com/kamranahmedse/pennywise/releases/tag/v${appVersion}`); } }, ] From 6c2cc9a63d33813d5b5efbc5e990d2e9efb8f2b3 Mon Sep 17 00:00:00 2001 From: Alex Ward Date: Fri, 30 Nov 2018 13:12:05 +0000 Subject: [PATCH 4/4] Make 'empty-page' responsive (#71) * change `px` values in empty-page to be `vh` * use media queries instead of vh * redo element removal order --- src/components/empty-page/style.scss | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/src/components/empty-page/style.scss b/src/components/empty-page/style.scss index 87b6625..d81b78b 100644 --- a/src/components/empty-page/style.scss +++ b/src/components/empty-page/style.scss @@ -12,18 +12,24 @@ h1 { font-weight: 700; font-size: 55px; - margin-bottom: 10px; + margin-bottom: 1vh; + @media (max-height: 140px) { + display: none; + } } p { font-size: 18px; font-weight: 500; + @media (max-height: 190px) { + display: none; + } } input { font-size: 18px; font-weight: 500; - margin-top: 15px; + margin-top: 1.5vh; padding: 15px 20px; box-shadow: none; border-radius: 80px; @@ -35,9 +41,17 @@ } svg { - width: 250px; - height: 250px; - margin-bottom: 20px; + width: 50vh; + margin-bottom: 2vh; + @media (max-height: 400px) { + width: 40vh; + } + @media (max-height: 320px) { + width: 30vh; + } + @media (max-height: 250px) { + display: none; + } } }