Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

akash-provider: move run.sh into a standalone file #16

Closed
boz opened this issue Feb 20, 2022 · 1 comment
Closed

akash-provider: move run.sh into a standalone file #16

boz opened this issue Feb 20, 2022 · 1 comment
Assignees

Comments

@boz
Copy link
Contributor

boz commented Feb 20, 2022

So that it can be linted and tested outside of a pod.

https://github.com/ovrclk/helm-charts/blob/b52f46016de4a4516c6a4711fecead0cb58d7bbf/charts/akash-provider/templates/configmap-boot.yaml#L7-L69

@arno01
Copy link
Contributor

arno01 commented May 14, 2022

Here is a PR #41 that moves run.sh into a standalone file.

It is till in the form of template though.
Not sure if we want to go beyond this point further and make it entirely non-template-based as one won't be able to test it straight away, unless setting all the environment variables correctly which are also templated here https://github.com/ovrclk/helm-charts/blob/c10fa285da5c72a396e28ad61615632b029048d5/charts/akash-provider/templates/deployment.yaml#L60-L154

run.sh is currently having two parts where it needs to be templated:

We could probably use another two template-based configmaps and let run.sh script read those files instead, but, I think that will be too over-engineered.

Upd:

And, ideally, the docker image should only run akash provider run (get configs via the env. variables only), and configmaps only to deliver the config files (provider.yaml, etc).
But since this run.sh script does more things such as provider attributes update, certificate registration, etc.. these steps should probably really be separated as suggested here #9 (comment)

@andy108369 andy108369 assigned andy108369 and unassigned arno01 Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants