Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of Docker Compose in app #75

Closed
akauppi opened this issue Aug 2, 2021 · 2 comments
Closed

Use of Docker Compose in app #75

akauppi opened this issue Aug 2, 2021 · 2 comments
Labels
HOT🔥 Something that should be fixed right now - delaying work!! packages/app Involves the package/app

Comments

@akauppi
Copy link
Owner

akauppi commented Aug 2, 2021 •
edited
Loading

This will fix #67 and allow CI to run Cypress tests.

Current problems:

  • running Vite within Docker Compose means HMR doesn't work

Follow vitejs/vite#4116 for the HMR issue.
@akauppi akauppi added HOT🔥 Something that should be fixed right now - delaying work!! packages/app Involves the package/app labels Aug 2, 2021
@akauppi akauppi pinned this issue Aug 2, 2021
@akauppi akauppi mentioned this issue Aug 2, 2021
Closed
@akauppi
Copy link
Owner Author

akauppi commented Aug 6, 2021

  •  Test next-docker-compose branch on Windows + WSL2

Let's close this once the developer experience works, and the code is merged to (at least) next.

@akauppi akauppi mentioned this issue Aug 6, 2021
Closed
@akauppi akauppi unpinned this issue Aug 13, 2021
@akauppi
Copy link
Owner Author

akauppi commented Aug 13, 2021

Merged also somewhat accidentally to master #73

Remains:

  • [. ] running Cypress tests
  • [. ] solving why HMR doesn't work from within Docker Compose

@akauppi akauppi closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HOT🔥 Something that should be fixed right now - delaying work!! packages/app Involves the package/app
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akauppi