Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window commands missing #402

Closed
morphles opened this issue Oct 15, 2014 · 13 comments
Closed

Window commands missing #402

morphles opened this issue Oct 15, 2014 · 13 comments

Comments

@morphles
Copy link

It seems VimFx has absolutely no support working with windows. At work I do not use tabs at all (though firefox tryies to make it as hard as possible), so support for bindings to open links in new windows would be needed, or maybe just an option to switch commands "oppend in new tab" to "open in new window".

@lydell
Copy link
Collaborator

lydell commented Oct 17, 2014

Interesting. I never use more than one Firefox window. It would be very interesting to hear more about why you prefer windows, and why you seem to only do so at work.

@morphles
Copy link
Author

Because I use tiling window manager (dwm) I do not really need tabs, window manager manages windows pretty fine, also they are much more accessible/flexible than tabs, I do not need to click on them (I use focus follows mouse) to get to content, I can also move them between "workspaces" (tags in dwm, or easily display some page on multiple tags). Tabs would not let me do any of that, and such things can be very useful when working. Though at home I tend to keep open much much more pages, so that breaks down (5 windows with 10-15 tabs each, is a bit much for dwm, though adopting certain ideas could allow managing them with little problem, for example Fluxbox has window tabs, so I see no need for apps to re-implement tabbing, worse of course). Managing windows is window managers job, I see tabs in browser as workarounds around sucky window managers on popular platforms (well even on Linux popular window managers seem rather sucky after using tiling wm paradigm :) ). So thats my story.

@RuiRojo
Copy link

RuiRojo commented Dec 4, 2014

Same here. I use a tiling WM (i3), and I still use Firefox tabs a lot but as "subtabs": I usually have about 5 windows around and 999999 tabs. When I want to open a link in a new window now I do vf to select the link, press the menu key, and choose to open in new window. It would be really convenient to have shortcuts to open links in new windows, or open all links in the same new window, or at least to move the current page to a new window, etc.
Btw, this addon is awesome.

@haxwithaxe
Copy link

i'd like the same ability for the same reason. i'd like to use a single unified window managemnet rather than similar tab management per application. i've been using uzbl but it has issues with many google services. what would really be cool is a fully exposed interface to firefox's controls that we can map key combos to, but i realize that is likely way more work than anyone is going to be willing to do any time soon :)

@lydell
Copy link
Collaborator

lydell commented Jan 19, 2015

I see. Since I only use one window, all I can say for now is: PRs welcome.

One thing I'd like to add, though, is the ability to extend VimFx with another extension. Imagine a "window commands for VimFx" extension.

@lydell
Copy link
Collaborator

lydell commented May 26, 2015

It was decided in #493 that we should add a Windows category of commands in addition to the Tabs category.

Please help by listing the commands you actually need and suggest default shortcuts for them!

@lydell
Copy link
Collaborator

lydell commented May 26, 2015

Possibly:

  • gF: Open link in new window
  • w: New window
  • W: New private window
  • gw: Move tab to new window
  • q: Close window
  • Q: Restore window

@sumit0190
Copy link

The defaults suggested look reasonable enough to me. But I wasn't aware of a 'restore window' functionality in Firefox. If I quit a window (regular or private), I see no way of restoring it back with all of its tabs. The pages visited in the now-gone window (if it was a regular one) do appear in the history, but clicking on those items restores the pages in the present window.

@morphles
Copy link
Author

I also agree that suggested commands seem to cover all what I can think of currently. Though maybe I'd like window closing to be a bit more involved maybe two keystrokes or modifier + q. But of course one can live with single letter:).

@lydell lydell added the feature label Jun 21, 2015
@lydell lydell mentioned this issue Sep 9, 2015
@lydell
Copy link
Collaborator

lydell commented Nov 14, 2015

Just realized that we shouldn’t add a command to close the window. Every operating system already has one, and many people customize it (I use super+q). Why learn a different way to close Firefox windows when you could use your existing muscle memory? Also, as @morphles points out, there’s a great risk such a command make more damage than good.

@tecepe
Copy link

tecepe commented Jun 13, 2016

Is it possible to add a shortcut to reopen a window, similar to what we have for tabs? For now, what I'm doing is: opening a new window and using the history the reach the last website visited.

@lydell
Copy link
Collaborator

lydell commented Jun 13, 2016

In the "History" menu there's a "Recently Closed Windows" sub-menu. From there, you can choose which window to restore. That menu also tells me that <c-s-n> is the default Firefox shortcut for restoring the most recently closed window. It is possible create custom VimFx commands that use these features. You need to figure out what code they use, and then use VimFx's tab commands as inspiration:

@ghost
Copy link

ghost commented Dec 16, 2016

FTR for this PR if someone also searchig for these commands. I added two custom commands to the wiki: Close Window and Minimize Window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants