Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<s-escape> does not exit ignore mode #568 #871

Closed
6 of 11 tasks
woctezuma opened this issue Mar 8, 2017 · 8 comments
Closed
6 of 11 tasks

<s-escape> does not exit ignore mode #568 #871

woctezuma opened this issue Mar 8, 2017 · 8 comments

Comments

@woctezuma
Copy link

woctezuma commented Mar 8, 2017

  • I've searched for duplicates – also closed issues
  • I've looked at the change log
  • I've provided the below details:

VimFx version: 0.20.9
Firefox version: 51.0.1 (32-bit)
OS: Windows 10
Keyboard language: French AZERTY
Example URL (if any): https://www.mozilla.org/en-US/about/

This is … (pick one!)

  • A bug report
    • I've filled in steps to reproduce below
  • A feature request
    • Sorry, feature requests are not accepted.
      See issue #860
  • A question
  • Something else

This bug is about … (pick one!)

  • A missing hint marker on a specific page
  • VimFx not recognizing a text input on a specific page
  • Something else

Steps to reproduce:

  1. Go to any webpage, e.g. https://www.mozilla.org/en-US/about/
  2. Press i to enter ignore mode
  3. Press <s-escape>
  4. Optionally, press <s-F1> and notice that it works, it is just <s-escape> which does not work

Expected result: Enter normal mode

Actual result: Still in ignore mode

@lydell
Copy link
Collaborator

lydell commented Mar 8, 2017

Thanks for the issue!

I can’t reproduce this. Could you try with a new Firefox profile, just to make sure there’s nothing wrong with your configuration?

@letientai299
Copy link

@woctezuma Just notice that you use different keyboard layout. Could you try again with English keyboard? I think that the source of the problem.

@woctezuma
Copy link
Author

woctezuma commented Mar 8, 2017

@lydell I have tried with a fresh Firefox profile, and the issue is still there.

@letientai299 I have tried switching from French to English using the Alt+Shift Windows shortcut, and the issue is still there.

Also, I would like to point out that the Escape key works, for instance to quit the Visual mode. The Shift key also works, for instance to quit the Ignore mode and apply only one command with <s-F1>. The issue is solely with <s-escape>.

@lydell
Copy link
Collaborator

lydell commented Mar 8, 2017

@woctezuma

  1. Go to VimFx's settings page in the Add-ons Manager.
  2. Foucs the text input for the "Return to Normal mode" command for Ignore mode.
  3. <c-q><s-escape>

Expected behavior: The text <s-escape> is inserted into the text input.

What happens for you?

A similar experiment:

  1. Press m<s-escape>.

Expected behavior: A notification appears, saying "Mark set: <s-escape>".

What happens for you?

@woctezuma
Copy link
Author

woctezuma commented Mar 8, 2017

@lydell

Result for the first experiment: nothing is inserted. I have tried other commands following <c-q> such as <c-s> or <escape> and both work. However, <s-escape> does not. In the meantime, I will be using your trick <c-q><escape> to set the command to <escape> to be able to quit ignore mode.

For the second experiment, is it still for the text input for the "Return to Normal mode" command for Ignore mode?

@lydell
Copy link
Collaborator

lydell commented Mar 8, 2017

No, the second experiment is about the "Mark scroll position" command. When you press m a notification appears, saying "Mark scroll position (press a key…)". I suspect that nothing in particular will happen when you then press <s-escape>, and that notification to still be there.

I seems as if Firefox does not receive the <s-escape> key press at all. Some other program or your operating system must be eating it.

For a very short time, the default shortcut was <c-escape>, but it was changed to <s-escape> to support Windows: #441.

@woctezuma
Copy link
Author

woctezuma commented Mar 8, 2017

You are right. I have looked for the possible culprit and I have found this page on StackOverflow. It turns out I do have this PIconStartup.exe in my msconfig startup menu. I also have Intel Management and Security Status in the tray notification part of the Windows task bar.

Sorry for thinking there was a bug with the addon! 🙈

By the way, you were right for the 2nd experiment. I wanted to post the result earlier but my Internet went off. Result for the second experiment, there is a notification in the bottom right corner that the extension is waiting for an input, however nothing is set with <s-escape>. Other markers such as ma and then 'a work.

@lydell
Copy link
Collaborator

lydell commented Mar 8, 2017

Nice find! 👍

@lydell lydell closed this as completed Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants