Added testing infrastructure: karma, jasmine and chrome #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexzhukov
reviewed
Apr 17, 2017
package.json
Outdated
| @@ -87,7 +88,17 @@ | |||
| "gh-pages": "0.12.0", | |||
| "html-webpack-plugin": "2.28.0", | |||
| "imports-loader": "0.7.1", | |||
| "istanbul-instrumenter-loader": "^2.0.0", | |||
There was a problem hiding this comment.
@Deilan please update yarn lock file.
There was a problem hiding this comment.
@lexzhukov Well, I didn't have prior experience with yarn. Launched yarn at the root, yarn.lock got updated resulting in a lots of changes in the file. If I did something wrong, please let me know.
There was a problem hiding this comment.
I also locked istanbul-instrumenter-loader's version to "2.0.0" to make it more consistent with the rest of the packages.
|
@Deilan thanks for PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Adding testing infrastructure: karma, jasmine and chrome
What is the current behavior? (You can also link to an open issue here)
No testing infrastructure Add test infrastructure: karma, jasmine and headless chrome #973
What is the new behavior (if this is a feature change)?
Testing infrastructure in place: karma, jasmine and chrome.
One sample test for App component.
Other information:
Took the most part from the upstream AngularClass/angular2-webpack-starter