New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to RxJava 2 #48

Closed

bnorm wants to merge 1 commit into alaisi:master from bnorm:bn/rxjava2

bnorm commented Aug 2, 2017 •

edited

Loading

Fixes: #47

Some notes on the changes:

I made use of Single and Completable where I felt appropriate. Since this is a pretty big API change, I thought it would be best to convert stuff to something more representative of the operation. (Plus, RxJava 2 does not allow nulls)
I changed a few custom lift operations to common operators. I'm pretty confident I did this correctly as all the unit tests passed.

More than happy to update anything, just let me know.


          Update to RxJava 2

9a76024

iferca commented Feb 10, 2018

@alaisi Any plans to review this PR? How about that core library and wrap it using Rx or Reactor, have something started that can be continued?

bnorm closed this

bnorm deleted the bn/rxjava2 branch

August 8, 2019 19:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet