From 6d1526f10065b003a9c280b77045bef50d2250b7 Mon Sep 17 00:00:00 2001 From: Andrew Lamb Date: Wed, 19 Jul 2023 06:05:40 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com> --- datafusion/core/src/physical_plan/aggregates/order/full.rs | 2 +- datafusion/core/src/physical_plan/aggregates/order/partial.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/datafusion/core/src/physical_plan/aggregates/order/full.rs b/datafusion/core/src/physical_plan/aggregates/order/full.rs index d4cd203c0988..d95433a998f7 100644 --- a/datafusion/core/src/physical_plan/aggregates/order/full.rs +++ b/datafusion/core/src/physical_plan/aggregates/order/full.rs @@ -129,7 +129,7 @@ impl GroupOrderingFull { batch_hashes: &[u64], total_num_groups: usize, ) { - assert!(total_num_groups > 0); + assert_ne!(total_num_groups, 0); assert_eq!(group_indices.len(), batch_hashes.len()); // copy any hash values diff --git a/datafusion/core/src/physical_plan/aggregates/order/partial.rs b/datafusion/core/src/physical_plan/aggregates/order/partial.rs index c19402d27fb7..a0f81ff4169e 100644 --- a/datafusion/core/src/physical_plan/aggregates/order/partial.rs +++ b/datafusion/core/src/physical_plan/aggregates/order/partial.rs @@ -91,7 +91,7 @@ enum State { /// Data is in progress. InProgress { - /// first group index with the sort_key + /// Smallest group index with the sort_key current_sort: usize, /// The sort key of group_index `current_sort` sort_key: OwnedRow,