Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump alexapy to 1.28.2 #2434

Merged
merged 8 commits into from
Aug 8, 2024
Merged

Conversation

chrisvblemos
Copy link
Contributor

@chrisvblemos chrisvblemos commented Aug 8, 2024

Critical to fix all issues related to non .com domains.

Fixes #2433, #2430, #2429, #2427, #2426, #2418, #2407

@chrisvblemos
Copy link
Contributor Author

pre-commit.ci autofix

@alandtse
Copy link
Owner

alandtse commented Aug 8, 2024

Can you please check the dev container for other users of alexapy? You can text search the repo or look at other bumps. I believe there are two more places for the bump.

@chrisvblemos
Copy link
Contributor Author

Can you please check the dev container for other users of alexapy? You can text search the repo or look at other bumps. I believe there are two more places for the bump.

Done. Don't know why the change wasn't initially commited. Mea culpa for not checking the diffs. Checked other bumps, don't think anything is missing other than bumping python to 3.11. Let me know if you still think there is something missing.

@jleinenbach
Copy link
Contributor

Sorry, I did the same to the same time and didn't see this PR. But I had to go up to Python 3.12 because of build issues.

@chrisvblemos
Copy link
Contributor Author

Added changes to devcontainer/Dockerfile. Project is now buildable using devcontainer, tested locally. Thanks to @jleinenbach for the suggestion. There are a few differences from your initial approach to better comply with recommendations, and it is working with python 3.11.

Ready for review @alandtse .

@alandtse alandtse merged commit 802c5c6 into alandtse:dev Aug 8, 2024
4 checks passed
alandtse added a commit that referenced this pull request Aug 8, 2024
fix: bump alexapy to 1.28.2 (#2434)
@danielbrunt57
Copy link
Collaborator

@chrisvblemos Can we now bump alexapy to 1.29.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Home Assistant Configuration in HAss Core 2024.8.0
4 participants