-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump alexapy to 1.28.2 #2434
Conversation
for more information, see https://pre-commit.ci
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Can you please check the dev container for other users of alexapy? You can text search the repo or look at other bumps. I believe there are two more places for the bump. |
Done. Don't know why the change wasn't initially commited. Mea culpa for not checking the diffs. Checked other bumps, don't think anything is missing other than bumping python to 3.11. Let me know if you still think there is something missing. |
Sorry, I did the same to the same time and didn't see this PR. But I had to go up to Python 3.12 because of build issues. |
Added changes to devcontainer/Dockerfile. Project is now buildable using devcontainer, tested locally. Thanks to @jleinenbach for the suggestion. There are a few differences from your initial approach to better comply with recommendations, and it is working with python 3.11. Ready for review @alandtse . |
fix: bump alexapy to 1.28.2 (#2434)
@chrisvblemos Can we now bump alexapy to 1.29.0? |
Critical to fix all issues related to non .com domains.
Fixes #2433, #2430, #2429, #2427, #2426, #2418, #2407