Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection of locale to be based on user #79

Closed
alandtse opened this issue Feb 20, 2019 · 3 comments · Fixed by #175
Closed

Fix selection of locale to be based on user #79

alandtse opened this issue Feb 20, 2019 · 3 comments · Fixed by #175
Assignees
Labels
alexapy Issue relates to the API bug Something isn't working question Further information is requested

Comments

@alandtse
Copy link
Owner

alandtse commented Feb 20, 2019

Currently, we hardcode EN-US as the locale for much of the selection. It appears to cause no issues so far, but it may in the future.

Spawned from #74 where umlauts were not processed correctly by Amazon.

@alandtse alandtse added bug Something isn't working alexapy Issue relates to the API labels Feb 20, 2019
@alandtse alandtse added the question Further information is requested label Mar 2, 2019
@keatontaylor
Copy link
Collaborator

I don't see a good solution for this. Any API endpoints where we could get the users locale would still require us to login with a default locale and be subject to the same issues if amazon at any point starts enforcing the locale to be correct.

With that said it might only make sense to build a map of locales based on the URL provided by the user. I don't believe this will change, but I could be wrong, please chime in with feedback @alandtse

@alandtse
Copy link
Owner Author

I think the locale for login may not matter since we haven't seen any errors that seem tied to that yet. There is actually a variable that could be replaced in routines with the appropriate device specific locale found from device preferences.

"locale":"ALEXA_CURRENT_LOCALE"

Currently, we don't do any replacement of this value, but we probably should at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alexapy Issue relates to the API bug Something isn't working question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants