fix: allow passing undefined to reader next method #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `bytes` value is optional and null-guarded so we can accept undefined as a value.
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=======================================
Coverage 89.29% 89.29%
=======================================
Files 2 2
Lines 299 299
Branches 39 39
=======================================
Hits 267 267
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Mar 8, 2022
### [5.0.1](v5.0.0...v5.0.1) (2022-03-08) ### Bug Fixes * allow passing undefined to reader next method ([#14](#14)) ([9944de0](9944de0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
bytesvalue is optional and null-guarded so we can accept undefined as a value.