-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v4.0.0 mega thread #77
Comments
If anyone wants to help update the test suite for v4, please see #81. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Seems there were two bugs. Please try v4.0.1
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@aleclarson I can at least confirm that 4.0.1 fixed our concrete instance of the problem. Thanks for the fast update! |
@aleclarson sorry for the delay, looks like everyone else got to this quickly and discovered the issue (thank you!) I can also confirm 4.0.1 fixed the specific issue I was having. |
This comment was marked as outdated.
This comment was marked as outdated.
@aniravi24 @DreierF for Nx:
I put in a PR to address that. Other than this, it should work as expected. |
This comment was marked as outdated.
This comment was marked as outdated.
It would be great if the Releases page were updated with information about this new major version |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Please try v4.0.3 if you're on Windows. Thanks to @joshwooding |
v4.0.3 is working on Windows with latest vite. Thanks @aleclarson & @joshwooding! |
Hi, it'd be nice if GH release page is up-to-date with release tags as well as changelog is mentioned somewhere. |
Would it be possible to have this work also with |
Introducing v4.0.0
Stop using the
tsconfig-paths
packageIt is better to let Vite handle all of the resolving, so that this plugin can be only responsible for the path mapping.
At the same time, I am also adding the
tsconfck
package, which handles the loading of tsconfig.json files for us. This package is also used in Vite core (we should have Vite expose it in the future, toavoid the duplication).
The
tsconfig-paths
package was previously responsible for config loading and much of the path resolving logic, but now we can ditch it! I'm also ditching therecrawl-sync
package, which was used for crawling the filesystem in search of tsconfig.json files.Remove the
extensions
optionSince the file resolution is delegated to Vite core, this option is no longer necessary.
Add the
parseNative
optionThe
tsconfck
package has aparseNative
function that's able to delegate config loading to the TypeScript compiler. If you encounter a bug intsconfig.json
file loading, you can try passingparseNative: true
to see if that helps. But you should avoid enabling it otherwise, since it has a noticeable performance cost (up to 600ms roughly speaking).Fixes #54
Closes #73
Probably fixes #63
Probably fixes #68
Probably fixes #71
Bugs down here 👇
I don't expect there to be bugs, but we don't currently have an extensive test suite, so it's possible. If you find any, let me know and (if you're feeling extra generous) open a PR with a reproduction in the
./demo
folder.tsconfck
package doesn't supportjsconfig.json
files, sovite-tsconfig-paths
has lost the support that was added in v3. See Support jsconfig.json #22The text was updated successfully, but these errors were encountered: