Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Preload Link Tags To Head #7

Closed
shadowtime2000 opened this issue Nov 2, 2020 · 4 comments · Fixed by #9
Closed

Add Preload Link Tags To Head #7

shadowtime2000 opened this issue Nov 2, 2020 · 4 comments · Fixed by #9
Labels
∆ feature New feature
Milestone

Comments

@shadowtime2000
Copy link
Member

Because this project does not bundle the output of a build it is importing from links at runtime. We should probably add <link rel="preload" /> tags in the header for the static output so the browser knows to start fetching those files.

@ije ije added the ∆ feature New feature label Nov 3, 2020
@ije
Copy link
Member

ije commented Nov 3, 2020

that makes sense

@ije
Copy link
Member

ije commented Nov 3, 2020

you can check #5 optimize section, this is in the plan

@ije ije mentioned this issue Nov 3, 2020
30 tasks
@ije ije closed this as completed in #9 Nov 3, 2020
@shadowtime2000
Copy link
Member Author

Continuing a conversation from Discord, the preloading of scripts/modules should be improved to preload the actual scripts which are used from the <script> tags. The rust compiler #28 could output a dependency graph which could be used for stuff like this. We will also need to change this for production when it will bundle the dependencies.

@shadowtime2000 shadowtime2000 added this to the v0.3.0 milestone Dec 26, 2020
mohsenkhanpour pushed a commit to mohsenkhanpour/aleph.js that referenced this issue Jan 29, 2021
Update Feature List styles to match intent
@ije
Copy link
Member

ije commented Feb 4, 2021

preload scripts is done in production mode, no need in dev

@ije ije closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
∆ feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants