fix: add the missed return before the callback when handleExistingLam…

…bda fails in upgrade command (#67)
alexa · Mar 25, 2020 · 6b941af · 6b941af
1 parent ff3c2a0
commit 6b941af
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 6 deletions.
diff --git a/PROJECT_PATH/ask-resources.json b/PROJECT_PATH/ask-resources.json
diff --git a/lib/commands/util/upgrade-project/index.js b/lib/commands/util/upgrade-project/index.js
@@ -99,7 +99,7 @@ function _createV2HostedSkillProject(upgradeInfo, profile, doDebug, callback) {
         try {
             hostedSkillHelper.handleExistingLambdaCode(rootPath, gitRepoUrl, profile);
         } catch (codeErr) {
-            callback(codeErr);
+            return callback(codeErr);
         }
         // 5. config git setting
         hostedSkillHelper.postUpgradeGitSetup(profile, doDebug, gitClient, (gitErr) => {

diff --git a/test/unit/commands/util/upgrade-project/hosted-skill-helper-test.js b/test/unit/commands/util/upgrade-project/hosted-skill-helper-test.js
@@ -13,7 +13,6 @@ const ResourcesConfig = require('@src/model/resources-config');
 const CLiError = require('@src/exceptions/cli-error');
 const CONSTANTS = require('@src/utils/constants');
 
-//
 describe('Commands upgrade-project test - hosted skill helper test', () => {
     const TEST_ERROR = 'testError';
     const TEST_PROFILE = 'default';