fix: upgraded nodejs from v8 to v10 & fixed validate lambda deploy st…

…ate issue
alexa · Dec 25, 2019 · e18b1df · e18b1df
1 parent 524a951
commit e18b1df
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 7 deletions.
diff --git a/lib/builtins/deploy-delegates/lambda-deployer/helper.js b/lib/builtins/deploy-delegates/lambda-deployer/helper.js
@@ -43,10 +43,10 @@ Please solve this IAM role mismatch and re-deploy again.`);
             return callback(`The current revisionId (The revision ID for Lambda ARN (${lambdaArn}) should be ${remoteRevisionId}, \
 but found ${localRevisionId}. Please solve this revision mismatch and re-deploy again.`);
         }
-        updatedDeployState = R.set(R.lensPath(['lambda', 'revisionId']), remoteRevisionId, currentRegionDeployState);
+        updatedDeployState = R.set(R.lensPath(['lambda', 'revisionId']), remoteRevisionId, updatedDeployState);
         // 3. add lastModified
         const lastModified = data.Configuration.LastModified;
-        updatedDeployState = R.set(R.lensPath(['lambda', 'lastModified']), lastModified, currentRegionDeployState);
+        updatedDeployState = R.set(R.lensPath(['lambda', 'lastModified']), lastModified, updatedDeployState);
         callback(null, { updatedDeployState });
     });
 }

diff --git a/lib/utils/constants.js b/lib/utils/constants.js
@@ -105,7 +105,6 @@ module.exports.TEMPLATES = {
         NodeJS: {
             TEMPLATE_INDEX: 'https://ask-cli-static-content.s3-us-west-2.amazonaws.com/skill-templates/nodejs-templates.json',
             LAMBDA_RUNTIME: [
-                'nodejs8.10',
                 'nodejs10.x'
             ]
         },

diff --git a/test/unit/fixture/model/regional-stack-file.json b/test/unit/fixture/model/regional-stack-file.json
@@ -50,7 +50,7 @@
           "S3Key": "endpoint.s3.key",
           "S3ObjectVersion": "endpoint.s3.version"
         },
-        "Runtime": "nodejs8.10",
+        "Runtime": "nodejs10.x",
         "MemorySize": 512,
         "Timeout": 60
       }

diff --git a/test/unit/fixture/model/regional-stack-file.yaml b/test/unit/fixture/model/regional-stack-file.yaml
@@ -31,7 +31,7 @@ Resources:
         S3Bucket: endpoint.s3.bucket
         S3Key: endpoint.s3.key
         S3ObjectVersion: endpoint.s3.version
-      Runtime: nodejs8.10
+      Runtime: nodejs10.x
       MemorySize: 512
       Timeout: 60
   AlexaSkillFunctionEventPermission:

diff --git a/test/unit/fixture/model/resources-config.json b/test/unit/fixture/model/resources-config.json
@@ -24,7 +24,7 @@
       "skillInfrastructure": {
         "type": "@ask-cli/cfn-deployer",
         "userConfig": {
-          "runtime": "nodejs8.10",
+          "runtime": "nodejs10.x",
           "handler": "index.handler",
           "template": "./awsStacks/skill-infra.yaml",
           "regionOverrides": {

diff --git a/test/unit/fixture/model/resources-config.yaml b/test/unit/fixture/model/resources-config.yaml
@@ -18,7 +18,7 @@ profiles:
     skillInfrastructure:
       type: "@ask-cli/cfn-deployer"
       userConfig:
-        runtime: nodejs8.10
+        runtime: nodejs10.x
         handler: index.handler
         template: "./awsStacks/skill-infra.yaml"
         regionOverrides: