fix: askx new -> change the representation layer for deployers #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbheemag
reviewed
Apr 7, 2020
|
Need a rebase so that the CI fix can be included. |
…sk-cli into deployer-representation-fix
RonWang
reviewed
Apr 7, 2020
lib/commands/v2new/ui.js
Outdated
Comment on lines
119
to
124
| // eslint-disable-next-line array-callback-return | ||
| R.values(deployType).map((deployer) => { | ||
| if (answer.deployDelegate === deployer.OPTION_NAME) { | ||
| return callback(null, deployer.NAME); | ||
| } | ||
| }); |
There was a problem hiding this comment.
I think if not understanding that the loop will only hit the target once, putting the callback inside a for loop looks not good. The eslint actually makes sense and we should not ignore. I think you can use try
callback(null, R.find(R.propEq('OPTION_NAME', 'AWS Lambda'))(R.values(deployType)).NAME)
There was a problem hiding this comment.
This solution is much better, it returns the first element of the list which matches the predicate, or undefined if no element matches.
RonWang
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.