From 33fcf1f62eebc50eef785e47f352b266785de440 Mon Sep 17 00:00:00 2001
From: KS <kevinseq1@gmail.com>
Date: Fri, 26 Feb 2021 10:25:56 -0800
Subject: [PATCH] fix(lambda): Removed ternary operator

---
 lib/clients/aws-client/iam-client.js | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/clients/aws-client/iam-client.js b/lib/clients/aws-client/iam-client.js
index 26945bd2..e87ff7d8 100644
--- a/lib/clients/aws-client/iam-client.js
+++ b/lib/clients/aws-client/iam-client.js
@@ -78,8 +78,7 @@ module.exports = class IAMClient extends AbstractAwsClient {
      */
     _generateIAMRoleName(skillName) {
         const roleNamePrefix = process.env.ASK_DEPLOY_ROLE_PREFIX || 'ask-lambda';
-        const validSkillName = skillName.replace(/_/g, '-');
-        const truncatedSkillName = (validSkillName.length > 39) ? validSkillName.substr(0, 39 - 1) : validSkillName;
-        return `${roleNamePrefix}-${truncatedSkillName}-${Date.now()}`;
+        const validSkillName = skillName.replace(/_/g, '-').substr(0, 39 - 1);
+        return `${roleNamePrefix}-${validSkillName}-${Date.now()}`;
     }
 };