-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: parse order of parameters from function source code #112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with some further work coming up, mostly minor and about testing
|
||
_autoRegisterHooks(); | ||
_manualRegisterHooks(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, add a new line after this line
@@ -12,6 +13,15 @@ module.exports = { | |||
validateSyntax | |||
}; | |||
|
|||
function getParamNames(func) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function need unit test
const STRIP_COMMENTS = /((\/\/.*$)|(\/\*[\s\S]*?\*\/))/mg; | ||
const ARGUMENT_NAMES = /([^\s,]+)/g; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a REGEX_VALIDATIONS in constants.js, should we try to put regex in one place?
the following command was failing before
ask smapi list-catalogs-for-vendor