fix: parse to correct data type for nested body parameter #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonWang
reviewed
Apr 15, 2020
|
Overall looks good to me~ |
Removed skip test. Merging once the Travis test passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commands were failing.
ask smapi create-content-upload -c amzn1.ask-catalog.cat.c98f84ac-6730-4043-8fa7-19c93447f214 --number-of-upload-parts 1
ask smapi generate-catalog-upload-url -c amzn1.ask-catalog.cat.c98f84ac-6730-4043-8fa7-19c93447f214 --number-of-upload-parts 1
with error: class java.lang.String can not be converted to an Integer
--number-of-upload-parts had to be converted to number before sending to smapi.
this command was failing
ask smapi generate-credentials-for-alexa-hosted-skill -s amzn1.ask.skill.e9ac9d7f-5c4f-4c3b-8e41-1b347f625d95 --repository-url https://git-codecommit.us-east-1.amazonaws.com/v1/repos/e9ac9d7f-5c4f-4c3b-8e41-1b347f625d95 --repository-type GIT
url and type were overwriting each other instead of merging to the same object.
this PR fixes this issues.