Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix to respect ask env variables for commands #167

Merged
merged 4 commits into from
May 6, 2020
Merged

fix: fix to respect ask env variables for commands #167

merged 4 commits into from
May 6, 2020

Conversation

kakhaUrigashvili
Copy link
Contributor

@kakhaUrigashvili kakhaUrigashvili commented May 6, 2020 •
edited
Loading

To deploy with env variables, the following env variables need to be set:

AWS_ACCESS_KEY_ID
AWS_SECRET_ACCESS_KEY
ASK_REFRESH_TOKEN
ASK_VENDOR_ID

There were 2 issues:

  1. even aws envs were set cli still tried to load credentials from .aws/credentials file
  2. even the variables mentioned above were set, the cli still tried load .ask/cli_config file (which is not needed if deploying using env variables).

Related issue #144

@kakhaUrigashvili kakhaUrigashvili marked this pull request as draft May 6, 2020 16:28
@kakhaUrigashvili kakhaUrigashvili marked this pull request as ready for review May 6, 2020 17:31
@kakhaUrigashvili kakhaUrigashvili mentioned this pull request May 6, 2020
Closed
RonWang
RonWang reviewed May 6, 2020
View reviewed changes
Copy link
Contributor

@RonWang RonWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just some minor comments

lib/clients/aws-client/abstract-client.js Outdated Show resolved Hide resolved
lib/commands/abstract-command.js Show resolved Hide resolved
lib/clients/aws-client/abstract-client.js Outdated Show resolved Hide resolved
@kakhaUrigashvili kakhaUrigashvili merged commit d63c955 into develop May 6, 2020
@kakhaUrigashvili kakhaUrigashvili deleted the fix-deploy-with-envs branch May 6, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonWang RonWang RonWang approved these changes

@Chih-Ying Chih-Ying Chih-Ying approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kakhaUrigashvili @RonWang @Chih-Ying